When the layout changes, the model fires the 'laidout' event.
The number of rows may have changed (when callstacks are shown or hidden, for
instance), and the values panel must be updated accordingly.

Maxime Jacquemin authored 3 years ago and David Bühler committed 3 years ago

It is a minor detail

Maxime Jacquemin authored 3 years ago and David Bühler committed 3 years ago

The bug was that a clic on the by callstack button would not display the
values of all callstacks, instead showing only the consolidated one and
a unique callstack. A second clic was necessary to perform the request,
update the caches and finally display the complete data.

The fix we use here is quite brutal: we invalidate the values cache in
the model. I would like to find a cleaner way.

Maxime Jacquemin authored 3 years ago and David Bühler committed 3 years ago

The Valuecomponent had lots of weird bugs, triggering the warning
<Can't perform a React state update on an unmounted component>.
This was caused by an ugly, full of unsafe effect, way to handle the
Model used by a lot of components used by the ValueComponent

Now, the Model is created only once by the ValueComponent itself, and
given as a property to every component that needs it.

As a consequence, the useModel() function is now useless.

The warning was:
  Cannot update a component from inside the function body of a different
  component

It happened because a call to the model's method <setOrderingByFields>
was done at each rendering, which somehow was a bad idea. Now it is done
during the model's creation, and everything's fine.

David Bühler authored 3 years ago and Maxime Jacquemin committed 3 years ago

The bottom panel is not shown by default: it appears at a click on a table
row, and can then be closed.

In the table, clips too long messages with an ellipsis '…'.
Increases the size of columns for the category and the function.

Maxime Jacquemin authored 3 years ago and David Bühler committed 3 years ago

For now I have the following:
  - A new preference that allows to specify which command to launch to
    edit the source code in the user's favorite editor;
  - Spawn a new process that launch the editor on the current selection
    using the specified command. The keybinding used is
    <Ctrl-LeftClick>, exactly as the old GUI.

However, there is a catch. First, the keybinding does not select a line
before launching the external editor. Second, the only selection that is
actually taken into consideration is the one done when we click on a
function.

Only shows the statement line in the table, do not print the filename, which
may be too long for the column.
In [StmtProps] interface, removes [rank], types [stmt] as an Ast marker,
and adds [short] boolean to not print the filename.

Maxime Jacquemin authored 3 years ago and David Bühler committed 3 years ago

Maybe we could factorize the code that read a file with the one from the
SourceCode component, as they look exactly the same.

In the messages and properties components.