Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

same issue as with compinfo

Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

it turns out that not all global varinfos are stored in Globals.Vars...

Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

same reason as for locals: latter formals can refer to former ones

Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

a local can be referenced in the type of another one, hence we can't
compare them in the same environment and update said environment
afterwards.

Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

actually, we visit the spec of a function at its first occurrence,
so that it is possible that some global logic definitions
that are used in the constract haven't been visited yet.

Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

Specifically if a global declaration `x` occurs between a
function declaration `f` and the definition of `f` which uses `x`

Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

Dereference of placeholder was occurring at toplevel and not under a closure,
leading to an assert failure if you tried to use it

Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

also working oracle for AST diff test

Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

take into account that varinfos can stem from kernel functions (namely if
we take their address), and that they are supposed to be declared before
we see them, so that we don't have to compare their types and attributes
at each use, but just check the entries in the environment (either local
or global depending on vglob).

Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

in case ppx rewriting depend upon each other, ocamlfind applies them in
the order in which they are found on the command line, merlin in _reverse_
order. We can't thus use the exact same list in both cases.

Virgile Prevosto authored 3 years ago and David Bühler committed 2 years ago

it looks like ppx_import and ppx_deriving could be useful