Skip to content
Snippets Groups Projects
  1. Mar 04, 2022
  2. Oct 05, 2021
  3. Sep 15, 2021
  4. Dec 03, 2020
  5. Aug 30, 2019
  6. Oct 03, 2018
    • Fonenantsoa Maurica's avatar
    • Fonenantsoa Maurica's avatar
    • Fonenantsoa Maurica's avatar
      Addresses Julien's review no.3 (part 1/2): · 74c8f25f
      Fonenantsoa Maurica authored
       - Sad goodbye to insert_before_element_under_condition
       - ~label instead of ~pre
       - No superfluous Env.Varname.get
       - Gmp only allowed
       - Dataflow analysis allowed
       - Using exception for term_has_lv_from_vi
       - Fix incorrect assert false from effective_lscope_from_pred_or_term
       - fold_left for index_from_sizes_and_shifts
      74c8f25f
    • Fonenantsoa Maurica's avatar
      Addresses Julien's review no.2: · 78f9aaab
      Fonenantsoa Maurica authored
      MAJOR:
      - malloc and free
        - Distinct tables for malloc and free
        - Efficient insertion of free and malloc
        - Remove entries for malloc and free when they are not needed anymore
      - Using kf instead of fundec
      - Using closure of vi_at: not (straightforwardly) possible
      - Logic scope:
        - No Lscope.top
        - Proper reseting of the lscope
        - Proper binding of logic variables
        - Module Env.Logic_scope
      - Comment for the over-approximation of t_size
      
      STYLE:
      - No useless new lines
      - Spaces
      - Parentheses
      - Latex style for formula in comment of index_from_sizes_and_shifts
      - match -> function
      - Logical variable -> logic variable
      - Renaming:
        - add_to_lscope ->  extend_lscope
        - memory_infos_from_quantifs -> sizes_and_shifts_from_quantifs
        - res -> sizes_and_shifts, memory_infos -> sizes_and_shifts
      - Typos
      - Forward references at the end of the mli
      - Consistent ordering of arguments inside Lscope API
      
      OTHERS:
      - Auxiliary function append_block_of_env_to_block
      - Squash pattern matching of mk_storing_loops
      - No Interval.infer in to_exp
      - Refactoring of pre_from_label
      - pi_beta_j with fold_left
      - No superfluous env for sizes_and_shifts_from_quantifs
      - More efficient accumulator for computing size
      - Squash pattern matching of sizes_and_shifts_from_quantifs
      - No superfluous option for get_lscope_var
      - Better definition of effective_lscope_from_pred_or_term
      - Using List.find for defining get_lscope_var
      - Do not export get_lscope_var
      - Lscope.empty () -> Lscope.empty
      78f9aaab
    • Fonenantsoa Maurica's avatar
      Addresses Julien's review no.1: · c9f1976f
      Fonenantsoa Maurica authored
      - No superfluous white space
      - No camel case
      - No unauthorized open
      - Longic_const.tinteger -> Cil.lone, Cil.lzero
      - lscope -> Lscope.t
      - lscope becomes abstract
      - 'with non-void logic scope' -> 'on purely logical variables'
      - Make lscope be part of env
      - Discard all the translation in a new module: At_with_lscope
      - No extra variable for size
      - Cil.(theMachine.typeOfSizeOf) instead of Cil.intType
      - No superfluous block for storing_loops
      - mem_infos -> memory_infos
      - Prevent GMP result (actually already done previously)
      - record for malloc and free
      - H_malloc_free = Cil_datatype.Fundec.Hashtbl
      - dedicated insert_malloc_and_free_stmts in Visit
      - Kernel_function.is_entry_point for testing main function
      - no visit in term_has_lv_from_vi and effective_lscope_from_pot
      - term_has_lv_from_vi moved to Misc
      - Passing kf to add_malloc_and_free_stmt instead of fundec
      - Less @ during the insertion of free stmts
      - ty_array -> ty_ptr
      - Typos
      - Comments on:
        - Exported functions in MLIs
        - Computation of pre in put_block_at_label
        - Use of global scope for Env.Varname.get
        - Description of mk_storing_loops
        - New binding in mk_storing_loops
        - Description of effective_lscope_from_pred_or_term
        - Motivation of the over-approximation on t_size
      c9f1976f
    • Fonenantsoa Maurica's avatar
      \at with non-void logic scope. · 26cef0ce
      Fonenantsoa Maurica authored
      26cef0ce
Loading