[ivette] lint: update the set of rules according to the current discussions

ivette/.eslintrc.js

@@ -40,17 +40,15 @@ module.exports = {
     "lines-between-class-members": [
       "error", "always", { "exceptAfterSingleLine": true }
     ],
-    // Disallow the use of var in favor of let and const
-    "no-var": "error",
     // Force curly brackets on newline if some item is
     "object-curly-newline": ["error", { "multiline": true }],
+    // Allow infinite loops but disallow constant if-then-else
+    "no-constant-condition": ["error", { "checkLoops": false }],
 
     // --- Safety rules ---
 
     // Be more strict on usage of useMemo and useRef
     "react-hooks/exhaustive-deps": "error",
-    // Forbid shadowing concerning variables
-    "no-shadow": "off",
     // Requires '+' to be applied on 2 numbers or 2 strings only
     "@typescript-eslint/restrict-plus-operands": "error",
     // Only use type safe comparison === as == between distinct type is not so obvious
@@ -64,12 +62,7 @@ module.exports = {
         "varsIgnorePattern": "^_",
         "argsIgnorePattern": "^_" }
     ],
-
-    // --- Laxism ---
-
-    // Allow type any until we have types for every external library
-    "@typescript-eslint/no-explicit-any": "off",
-    // Actually, allow any function without return type for now
-    "@typescript-eslint/explicit-function-return-type": "off",
+    // Disallow the use of var in favor of let and const
+    "no-var": "error",
   }
 };

ivette/src/dome/.eslintrc.json

+{ 
+    "rules": {
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/explicit-function-return-type": "off"
+    }
+}
\ No newline at end of file

ivette/src/dome/renderer/data/json.ts

@@ -453,6 +453,7 @@ export function eObject<A>(fp: EProps<A>): Encoder<A> {
 }
 
 // Intentionnaly internal and only declared
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 declare const tag: unique symbol;
 
 /** Phantom type. */

ivette/src/frama-c/.eslintrc.json

+{ 
+    "rules": {
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/explicit-function-return-type": "off"
+    }
+}
\ No newline at end of file

ivette/src/frama-c/plugins/eva/cells.ts

@@ -98,15 +98,15 @@ export type Evaluation = Values.evaluation;
 const emptyEvaluation: Values.evaluation = {
   value: '',
   alarms: [],
-  pointed_vars: [],
+  pointedVars: [],
 };
 
 export interface EvaValues {
   errors?: string;
-  v_before: Evaluation;
-  v_after?: Evaluation;
-  v_then?: Evaluation;
-  v_else?: Evaluation;
+  vBefore: Evaluation;
+  vAfter?: Evaluation;
+  vThen?: Evaluation;
+  vElse?: Evaluation;
   size: Size;
 }
 
@@ -166,7 +166,7 @@ export class ValueCache {
     const cache = this.vcache;
     const cached = cache.get(key);
     if (cached) return cached;
-    const newValue: EvaValues = { v_before: emptyEvaluation, size: EMPTY };
+    const newValue: EvaValues = { vBefore: emptyEvaluation, size: EMPTY };
     if (callstack !== undefined && fct === undefined)
       return newValue;
     // callstack !== undefined ==> fct !== undefined)
@@ -175,7 +175,7 @@ export class ValueCache {
       .send(Values.getValues, { target: marker, callstack })
       .then((r) => {
         newValue.errors = undefined;
-        if (r.v_before) newValue.v_before = r.v_before;
+        if (r.vBefore) newValue.vBefore = r.v_before;
         newValue.v_after = r.v_after;
         newValue.v_then = r.v_then;
         newValue.v_else = r.v_else;

ivette/src/ivette/.eslintrc.json

+{ 
+    "rules": {
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/explicit-function-return-type": "off"
+    }
+}
\ No newline at end of file

ivette/src/renderer/.eslintrc.json

+{ 
+    "rules": {
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/explicit-function-return-type": "off"
+    }
+}
\ No newline at end of file