[tests] refactor const-assignments.c to ensure first run does not have warnings

also make real errors for KO instructions

tests/syntax/const-assignments.c

@@ -12,6 +12,7 @@
    STDOPT: +" -cpp-extra-args=-DT7"
  EXIT:1
    STDOPT: +" -cpp-extra-args=-DT8"
+   STDOPT: +" -cpp-extra-args=-DT9" +"-kernel-warn-key typing:incompatible-types-call=abort"
 */
 /* The first run is correct. The others should fail, as they include invalid
    assignments to const lvalues. */
@@ -103,9 +104,11 @@ void mutable_test_call(__attribute__((__fc_initialized_object)) const S* s) {
   int a = 1;
   k1(a + (s + 2));
   k2(&(s + 2)->y);
+#ifdef T9
   /* KO: although s has the __fc_initialized_object attribute, z[0] has not (and
      cannot) and y is const. */
   k2(&s->z[0]->y);
+#endif
 }
 
 #ifdef T8

tests/syntax/oracle/const-assignments.0.res.oracle

 [kernel] Parsing const-assignments.c (with preprocessing)
-[kernel:typing:incompatible-types-call] const-assignments.c:108: Warning: 
-  expected 'int *' but got argument of type 'int const *': & (s->z[0])->y
 /* Generated by Frama-C */
 struct S {
    int x ;
@@ -45,7 +43,6 @@ void mutable_test_call(S const *s)
   int a = 1;
   k1((S *)((s + 2) + a));
   k2((int *)(& (s + 2)->y));
-  k2((int *)(& (s->z[0])->y));
   return;
 }
 

tests/syntax/oracle/const-assignments.1.res.oracle

 [kernel] Parsing const-assignments.c (with preprocessing)
-[kernel] const-assignments.c:21: User Error: 
+[kernel] const-assignments.c:22: User Error: 
   Cannot assign to non-modifiable lval x
 [kernel] User Error: stopping on file "const-assignments.c" that has errors. Add
   '-kernel-msg-key pp' for preprocessing command.

tests/syntax/oracle/const-assignments.10.res.oracle

+[kernel] Parsing const-assignments.c (with preprocessing)
+[kernel:typing:incompatible-types-call] const-assignments.c:110: Warning: 
+  expected 'int *' but got argument of type 'int const *': & (s->z[0])->y
+[kernel] User Error: warning typing:incompatible-types-call treated as fatal error.
+[kernel] User Error: stopping on file "const-assignments.c" that has errors. Add
+  '-kernel-msg-key pp' for preprocessing command.
+[kernel] Frama-C aborted: invalid user input.

tests/syntax/oracle/const-assignments.2.res.oracle

 [kernel] Parsing const-assignments.c (with preprocessing)
-[kernel] const-assignments.c:27: User Error: 
+[kernel] const-assignments.c:28: User Error: 
   Cannot assign to non-modifiable lval x
 [kernel] User Error: stopping on file "const-assignments.c" that has errors. Add
   '-kernel-msg-key pp' for preprocessing command.

tests/syntax/oracle/const-assignments.3.res.oracle

 [kernel] Parsing const-assignments.c (with preprocessing)
-[kernel] const-assignments.c:33: User Error: 
+[kernel] const-assignments.c:34: User Error: 
   Cannot assign to non-modifiable lval x
 [kernel] User Error: stopping on file "const-assignments.c" that has errors. Add
   '-kernel-msg-key pp' for preprocessing command.

tests/syntax/oracle/const-assignments.4.res.oracle

 [kernel] Parsing const-assignments.c (with preprocessing)
-[kernel] const-assignments.c:39: User Error: 
+[kernel] const-assignments.c:40: User Error: 
   Cannot assign to non-modifiable lval x
 [kernel] User Error: stopping on file "const-assignments.c" that has errors. Add
   '-kernel-msg-key pp' for preprocessing command.

tests/syntax/oracle/const-assignments.5.res.oracle

 [kernel] Parsing const-assignments.c (with preprocessing)
-[kernel] const-assignments.c:46: User Error: 
+[kernel] const-assignments.c:47: User Error: 
   Cannot assign to non-modifiable lval x_0
 [kernel] User Error: stopping on file "const-assignments.c" that has errors. Add
   '-kernel-msg-key pp' for preprocessing command.

tests/syntax/oracle/const-assignments.6.res.oracle

 [kernel] Parsing const-assignments.c (with preprocessing)
-[kernel] const-assignments.c:52: User Error: 
+[kernel] const-assignments.c:53: User Error: 
   Cannot assign to non-modifiable lval *x_0
 [kernel] User Error: stopping on file "const-assignments.c" that has errors. Add
   '-kernel-msg-key pp' for preprocessing command.

tests/syntax/oracle/const-assignments.7.res.oracle

 [kernel] Parsing const-assignments.c (with preprocessing)
-[kernel:typing:incompatible-types-call] const-assignments.c:60: Warning: 
+[kernel:typing:incompatible-types-call] const-assignments.c:61: Warning: 
   expected 'int *' but got argument of type 'int const *': & x
-[kernel:typing:incompatible-types-call] const-assignments.c:108: Warning: 
-  expected 'int *' but got argument of type 'int const *': & (s->z[0])->y
 /* Generated by Frama-C */
 struct S {
    int x ;
@@ -53,7 +51,6 @@ void mutable_test_call(S const *s)
   int a = 1;
   k1((S *)((s + 2) + a));
   k2((int *)(& (s + 2)->y));
-  k2((int *)(& (s->z[0])->y));
   return;
 }
 

tests/syntax/oracle/const-assignments.8.res.oracle

 [kernel] Parsing const-assignments.c (with preprocessing)
-[kernel:typing:incompatible-types-call] const-assignments.c:66: Warning: 
+[kernel:typing:incompatible-types-call] const-assignments.c:67: Warning: 
   expected 'int *' but got argument of type 'int const *': x_0
-[kernel:typing:incompatible-types-call] const-assignments.c:108: Warning: 
-  expected 'int *' but got argument of type 'int const *': & (s->z[0])->y
 /* Generated by Frama-C */
 struct S {
    int x ;
@@ -53,7 +51,6 @@ void mutable_test_call(S const *s)
   int a = 1;
   k1((S *)((s + 2) + a));
   k2((int *)(& (s + 2)->y));
-  k2((int *)(& (s->z[0])->y));
   return;
 }
 

tests/syntax/oracle/const-assignments.9.res.oracle

 [kernel] Parsing const-assignments.c (with preprocessing)
-[kernel:typing:incompatible-types-call] const-assignments.c:108: Warning: 
-  expected 'int *' but got argument of type 'int const *': & (s->z[0])->y
-[kernel] const-assignments.c:118: User Error: 
+[kernel] const-assignments.c:121: User Error: 
   Cannot assign to non-modifiable lval t->s.y
 [kernel] User Error: stopping on file "const-assignments.c" that has errors. Add
   '-kernel-msg-key pp' for preprocessing command.