[Markdown-report] placate SARIF validator

src/plugins/markdown-report/sarif.ml

@@ -460,6 +460,7 @@ module Driver = struct
     semanticVersion: (string [@default ""]);
     fileVersion: (string [@default ""]);
     downloadUri: (string [@default ""]);
+    informationUri: (string [@default ""]);
     sarifLoggerVersion: (string [@default ""]);
     language: (string [@default "en-US"]);
     properties: (Properties.t [@default Properties.default]);
@@ -472,13 +473,14 @@ module Driver = struct
       ?(semanticVersion="")
       ?(fileVersion="")
       ?(downloadUri="")
+      ?(informationUri="")
       ?(sarifLoggerVersion="")
       ?(language="en-US")
       ?(properties=Properties.default)
       ()
     =
     { name; fullName; version; semanticVersion; fileVersion;
-      downloadUri; sarifLoggerVersion; language; properties }
+      downloadUri; informationUri; sarifLoggerVersion; language; properties }
 
   let default = create ~name:"" ()
 end

src/plugins/markdown-report/sarif_gen.ml

@@ -28,8 +28,10 @@ let frama_c_sarif =
   let semanticVersion = Fc_config.version in
   let fullName = name ^ "-" ^ version in
   let downloadUri = "https://frama-c.com/download.html" in
+  let informationUri = "https://frama-c.com" in
   Tool.create
-    (Driver.create ~name ~version ~semanticVersion ~fullName ~downloadUri ())
+    (Driver.create ~name ~version ~semanticVersion ~fullName ~downloadUri
+       ~informationUri ())
 
 let get_remarks () =
   let f = Mdr_params.Remarks.get () in
@@ -226,7 +228,7 @@ let gen_run remarks =
   let uriBases = ("PWD", Sys.getcwd ()) :: Filepath.all_symbolic_dirs () in
   let uriBasesJson =
     List.fold_left (fun acc (name, dir) ->
-        (name, `Assoc [("uri", `String dir)]) :: acc
+        (name, `Assoc [("uri", `String ("file://" ^ dir ^ "/"))]) :: acc
       ) [] uriBases
   in
   let originalUriBaseIds =

src/plugins/markdown-report/tests/sarif/oracle/with-libc.sarif.clean

@@ -10,7 +10,8 @@
           "fullName": "frama-c-21.1+dev (Scandium)",
           "version": "21.1+dev (Scandium)",
           "semanticVersion": "21.1+dev",
-          "downloadUri": "https://frama-c.com/download.html"
+          "downloadUri": "https://frama-c.com/download.html",
+          "informationUri": "https://frama-c.com"
         }
       },
       "invocations": [
@@ -28,11 +29,14 @@
         }
       ],
       "originalUriBaseIds": {
-        "FRAMAC_SHARE": { "uri": "REPLACED_FOR_PTESTS_FRAMAC_SHARE" },
-        "FRAMAC_LIB": { "uri": "REPLACED_FOR_PTESTS_FRAMAC_LIB" },
-        "FRAMAC_PLUGIN": { "uri": "REPLACED_FOR_PTESTS_FRAMAC_PLUGIN" },
+        "FRAMAC_SHARE": { "uri": "file://REPLACED_FOR_PTESTS_FRAMAC_SHARE/" },
+        "FRAMAC_LIB": { "uri": "file://REPLACED_FOR_PTESTS_FRAMAC_LIB/" },
+        "FRAMAC_PLUGIN": {
+          "uri": "file://REPLACED_FOR_PTESTS_FRAMAC_PLUGIN/"
+        },
         "PWD": {
-          "uri": "REPLACED_FOR_PTESTS_PWD"
+          "uri":
+            "file://REPLACED_FOR_PTESTS_PWD/"
         }
       },
       "artifacts": [

src/plugins/markdown-report/tests/sarif/oracle/without-libc.sarif.clean

@@ -10,7 +10,8 @@
           "fullName": "frama-c-21.1+dev (Scandium)",
           "version": "21.1+dev (Scandium)",
           "semanticVersion": "21.1+dev",
-          "downloadUri": "https://frama-c.com/download.html"
+          "downloadUri": "https://frama-c.com/download.html",
+          "informationUri": "https://frama-c.com"
         }
       },
       "invocations": [
@@ -28,11 +29,14 @@
         }
       ],
       "originalUriBaseIds": {
-        "FRAMAC_SHARE": { "uri": "REPLACED_FOR_PTESTS_FRAMAC_SHARE" },
-        "FRAMAC_LIB": { "uri": "REPLACED_FOR_PTESTS_FRAMAC_LIB" },
-        "FRAMAC_PLUGIN": { "uri": "REPLACED_FOR_PTESTS_FRAMAC_PLUGIN" },
+        "FRAMAC_SHARE": { "uri": "file://REPLACED_FOR_PTESTS_FRAMAC_SHARE/" },
+        "FRAMAC_LIB": { "uri": "file://REPLACED_FOR_PTESTS_FRAMAC_LIB/" },
+        "FRAMAC_PLUGIN": {
+          "uri": "file://REPLACED_FOR_PTESTS_FRAMAC_PLUGIN/"
+        },
         "PWD": {
-          "uri": "REPLACED_FOR_PTESTS_PWD"
+          "uri":
+            "file://REPLACED_FOR_PTESTS_PWD/"
         }
       },
       "artifacts": [