Port to OCamlgraph 1.8.2
ID0001180: This issue was created automatically from Mantis Issue 1180. Further discussion may take place here.
Id | Project | Category | View | Due Date | Updated |
---|---|---|---|---|---|
ID0001180 | Frama-C | Kernel | public | 2012-05-16 | 2012-09-19 |
Reporter | mehdi | Assigned To | signoles | Resolution | fixed |
Priority | normal | Severity | minor | Reproducibility | always |
Platform | - | OS | - | OS Version | - |
Product Version | Frama-C Nitrogen-20111001 | Target Version | - | Fixed in Version | Frama-C Oxygen-20120901 |
Description :
Hi,
Recent OCamlgraph 1.8.2 has a non backward compatible change. The change is described in OCamlgraph's changelog as:
o Topological: fix bug when a cycle depends on another cycle. That breaks compatibility: the input graph must implement Sig.COMPARABLE instead of Sig.HASHABLE
The attached patch make Frama-c compile (and run properly :)) with OCamlgraph 1.8.2. I wasn't sure whether I should use Pervasives.compare or Datatype.Int.compare. I noticed that the latter is more used so I preferred it over the standard one. Comments on this patch are welcome.
The patch is rather straightforward and easy and I'm (almost) sure you already fixed that but maybe other Frama-C users will need it… and I'm sharing it here.
Regards,
Mehdi