From 894086f758197e4e77490d6e1bad3f9e545b62b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20B=C3=BChler?= <david.buhler@cea.fr> Date: Fri, 25 Mar 2022 14:57:56 +0100 Subject: [PATCH] [ivette] ASTinfo: fixes the dependency of a useEffect call. --- ivette/src/frama-c/kernel/ASTinfo.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ivette/src/frama-c/kernel/ASTinfo.tsx b/ivette/src/frama-c/kernel/ASTinfo.tsx index e538e042627..4db1300e626 100644 --- a/ivette/src/frama-c/kernel/ASTinfo.tsx +++ b/ivette/src/frama-c/kernel/ASTinfo.tsx @@ -310,14 +310,14 @@ export default function ASTinfo(): JSX.Element { React.useEffect(() => { markers.setLocations(selectedLoc, hoveredLoc); }, [markers, selectedLoc, hoveredLoc]); - const pinMarker = (location: States.Location) : void => { + const pinMarker = React.useCallback((location: States.Location) => { if (location?.marker) markers.setPinned(location?.marker, true); - }; + }, [markers]); React.useEffect(() => { States.MetaSelection.on(pinMarker); return () => States.MetaSelection.off(pinMarker); - }); + }, [pinMarker]); // Rendering const renderMark = (mark: Mark): JSX.Element | null => { const { marker } = mark; -- GitLab