From 7255c3dd9856c030dd4e18034f7a47981043f82a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20B=C3=BChler?= <david.buhler@cea.fr>
Date: Tue, 16 Jun 2020 10:55:17 +0200
Subject: [PATCH] [kernel] Fixes the bug reporting messages: uses gitlab
instead of the old bts.
---
src/kernel_services/analysis/service_graph.ml | 16 ++++++++++------
.../cmdline_parameters/cmdline.ml | 7 ++++---
.../erroneous/oracle/variadic-builtin.res.oracle | 2 +-
tests/misc/oracle/debug_category.16.res.oracle | 4 ++--
4 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/src/kernel_services/analysis/service_graph.ml b/src/kernel_services/analysis/service_graph.ml
index e145f6ea292..40be8864a66 100644
--- a/src/kernel_services/analysis/service_graph.ml
+++ b/src/kernel_services/analysis/service_graph.ml
@@ -125,10 +125,12 @@ struct
let edge_invariant src dst = function
| Inter_functions ->
if not (Vertex.equal src.root dst.root || dst.is_root) then
- Kernel.failure
+ Kernel.failure
"Correctness bug when computing services.\n\
-PLEASE REPORT AS MAJOR BUG on http://bts.frama-c.com with the following info.\n\
-Src:%s in %s (is_root:%b) Dst:%s in %s (is_root:%b)"
+ PLEASE REPORT AS MAJOR BUG on \
+ https://git.frama-c.com/pub/frama-c/issues \
+ with the following info.\n\
+ Src:%s in %s (is_root:%b) Dst:%s in %s (is_root:%b)"
(G.V.name src.node)
(G.V.name src.root.node)
src.is_root
@@ -137,10 +139,12 @@ Src:%s in %s (is_root:%b) Dst:%s in %s (is_root:%b)"
dst.is_root
| Inter_services | Both ->
if not (src.is_root && dst.is_root) then
- Kernel.failure
+ Kernel.failure
"Correctness bug when computing services.\n\
-PLEASE REPORT AS MAJOR BUG on http://bts.frama-c.com with the following info.\n\
-Src root:%s in %s (is_root:%b) Dst:%s in %s (is_root:%b) [2d case]"
+ PLEASE REPORT AS MAJOR BUG on \
+ https://git.frama-c.com/pub/frama-c/issues \
+ with the following info.\n\
+ Src root:%s in %s (is_root:%b) Dst:%s in %s (is_root:%b) [2d case]"
(G.V.name src.node)
(G.V.name src.root.node)
src.is_root
diff --git a/src/kernel_services/cmdline_parameters/cmdline.ml b/src/kernel_services/cmdline_parameters/cmdline.ml
index b9e34c5015c..c9149a34007 100644
--- a/src/kernel_services/cmdline_parameters/cmdline.ml
+++ b/src/kernel_services/cmdline_parameters/cmdline.ml
@@ -106,11 +106,11 @@ let get_backtrace () =
let request_crash_report =
Format.sprintf
- "Please report as 'crash' at http://bts.frama-c.com/.\n\
+ "Please report as 'crash' at https://git.frama-c.com/pub/frama-c/issues.\n\
Your Frama-C version is %s.\n\
Note that a version and a backtrace alone often do not contain enough\n\
information to understand the bug. Guidelines for reporting bugs are at:\n\
- http://bts.frama-c.com/dokuwiki/doku.php?id=mantis:frama-c:bug_reporting_guidelines\n"
+ https://git.frama-c.com/pub/frama-c/-/wikis/Guidelines-for-reporting-bugs\n"
Fc_config.version_and_codename
let protect = function
@@ -139,7 +139,8 @@ let protect = function
let name = long_plugin_name p in
Printf.sprintf
"%s aborted: unimplemented feature.%s\n\
- You may send a feature request at http://bts.frama-c.com with:\n\
+ You may send a feature request at \
+ https://git.frama-c.com/pub/frama-c/issues with:\n\
'[%s] %s'."
name (additional_info ()) name m
| e ->
diff --git a/src/plugins/variadic/tests/erroneous/oracle/variadic-builtin.res.oracle b/src/plugins/variadic/tests/erroneous/oracle/variadic-builtin.res.oracle
index 30f7e2cf18c..7af1312eace 100644
--- a/src/plugins/variadic/tests/erroneous/oracle/variadic-builtin.res.oracle
+++ b/src/plugins/variadic/tests/erroneous/oracle/variadic-builtin.res.oracle
@@ -1,5 +1,5 @@
[variadic] tests/erroneous/variadic-builtin.i:1:
Variadic builtin Frama_C_show_each_warning left untransformed.
[kernel] Plug-in variadic aborted: unimplemented feature.
- You may send a feature request at http://bts.frama-c.com with:
+ You may send a feature request at https://git.frama-c.com/pub/frama-c/issues with:
'[Plug-in variadic] The variadic plugin doesn't handle calls to a pointer to the variadic builtin Frama_C_show_each_warning.'.
diff --git a/tests/misc/oracle/debug_category.16.res.oracle b/tests/misc/oracle/debug_category.16.res.oracle
index 94d8b8d1965..a1b76fbcb82 100644
--- a/tests/misc/oracle/debug_category.16.res.oracle
+++ b/tests/misc/oracle/debug_category.16.res.oracle
@@ -8,8 +8,8 @@
The full backtrace is:
Plug-in test aborted: internal error.
- Please report as 'crash' at http://bts.frama-c.com/.
+ Please report as 'crash' at https://git.frama-c.com/pub/frama-c/issues.
Your Frama-C version is VERSION
Note that a version and a backtrace alone often do not contain enough
information to understand the bug. Guidelines for reporting bugs are at:
- http://bts.frama-c.com/dokuwiki/doku.php?id=mantis:frama-c:bug_reporting_guidelines
+ https://git.frama-c.com/pub/frama-c/-/wikis/Guidelines-for-reporting-bugs
--
GitLab