From 49c071f16102d9dac3ee440799a202d982496b4e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Loi=CC=88c=20Correnson?= <loic.correnson@cea.fr>
Date: Fri, 11 Sep 2020 15:02:35 +0200
Subject: [PATCH] [dome] re-introduce mutable record fields
---
ivette/.eslintrc.js | 2 +-
ivette/src/dome/src/renderer/dome.tsx | 2 +-
ivette/src/dome/src/renderer/table/arrays.ts | 2 --
ivette/src/dome/src/renderer/table/views.tsx | 2 --
4 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/ivette/.eslintrc.js b/ivette/.eslintrc.js
index 256118d6c6b..9f7e0ae0e26 100644
--- a/ivette/.eslintrc.js
+++ b/ivette/.eslintrc.js
@@ -102,7 +102,7 @@ module.exports = {
"default-case": "off",
"consistent-return": "off",
// Allow modify properties of object passed in parameter
- "no-param-reassign": "error", //[ "error", { "props": false } ],
+ "no-param-reassign": [ "error", { "props": false } ],
// Disallow the use of var in favor of let and const
"no-var": "error",
// Do not favor default import
diff --git a/ivette/src/dome/src/renderer/dome.tsx b/ivette/src/dome/src/renderer/dome.tsx
index 4ab30ec636e..261f6f1de31 100644
--- a/ivette/src/dome/src/renderer/dome.tsx
+++ b/ivette/src/dome/src/renderer/dome.tsx
@@ -508,7 +508,7 @@ const CLOCKEVENT = (period: number) => `dome.clock.${period}`;
const TIC_CLOCK = (clk: Clock) => () => {
if (0 < clk.pending) {
- clk.time += clk.period; // eslint-disable-line no-param-reassign
+ clk.time += clk.period;
System.emitter.emit(clk.event, clk.time);
} else {
if (clk.timer) clearInterval(clk.timer);
diff --git a/ivette/src/dome/src/renderer/table/arrays.ts b/ivette/src/dome/src/renderer/table/arrays.ts
index 5abe5992daa..9ab710b5b95 100644
--- a/ivette/src/dome/src/renderer/table/arrays.ts
+++ b/ivette/src/dome/src/renderer/table/arrays.ts
@@ -109,7 +109,6 @@ export class ArrayModel<Key, Row>
}
// Lazily compute table ; modifies packed entries in place
- /* eslint-disable no-param-reassign */
protected rebuild(): PACK<Key, Row>[] {
const current = this.table;
let filtered = 0;
@@ -133,7 +132,6 @@ export class ArrayModel<Key, Row>
this.filtered = filtered;
return table;
}
- /* eslint-enable no-param-reassign */
// --------------------------------------------------------------------------
// --- Proxy
diff --git a/ivette/src/dome/src/renderer/table/views.tsx b/ivette/src/dome/src/renderer/table/views.tsx
index c8ff5652821..14a43465331 100644
--- a/ivette/src/dome/src/renderer/table/views.tsx
+++ b/ivette/src/dome/src/renderer/table/views.tsx
@@ -1016,13 +1016,11 @@ function makeTable<Key, Row>(
const columns = makeColumns(state, cprops);
const resizers = makeResizers(state, cprops);
- /* eslint-disable no-param-reassign */
state.rowCount = rowCount;
if (state.width !== width) {
state.width = width;
setImmediate(state.forceUpdate);
}
- /* eslint-enable no-param-reassign */
return (
<div onKeyDown={state.onKeyDown}>
--
GitLab