From 43389849c43ee7192f6be1f3d923f05563b5b12d Mon Sep 17 00:00:00 2001
From: Andre Maroneze <andre.maroneze@cea.fr>
Date: Tue, 4 May 2021 10:58:09 +0200
Subject: [PATCH] [MdR] proper error message with missing -mdr-out

---
 src/plugins/markdown-report/md_gen.ml | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/src/plugins/markdown-report/md_gen.ml b/src/plugins/markdown-report/md_gen.ml
index b8a09ed3b99..8cd2ba469ab 100644
--- a/src/plugins/markdown-report/md_gen.ml
+++ b/src/plugins/markdown-report/md_gen.ml
@@ -609,10 +609,15 @@ let gen_report ~draft:is_draft () =
   in
   let doc = Markdown.pandoc ~title ~authors ?date elements in
   let file = Mdr_params.Output.get() in
-  try
-    Command.print_file (file:>string) (fun fmt -> Markdown.pp_pandoc fmt doc) ;
-    Mdr_params.result "Report %a generated" Filepath.Normalized.pretty file
-  with Sys_error s ->
-    Mdr_params.warning
-      "Unable to open %a for writing (%s). No report generated"
-      Filepath.Normalized.pretty file s
+  if Filepath.Normalized.is_empty file then
+    Mdr_params.error "No output file specified (use option %s)."
+      Mdr_params.Output.option_name
+  else
+    try
+      Command.print_file (file:>string)
+        (fun fmt -> Markdown.pp_pandoc fmt doc) ;
+      Mdr_params.result "Report %a generated" Filepath.Normalized.pretty file
+    with Sys_error s ->
+      Mdr_params.warning
+        "Unable to open %a for writing (%s). No report generated"
+        Filepath.Normalized.pretty file s
-- 
GitLab